ZettaKonsult/zetta-workspace

Unique reference id for invoice

Open

#97 opened on Mar 9, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (0 forks)auto 404
enhancementgood first issueinvoice

Repository metrics

Stars
 (0 stars)
PR merge metrics
 (PR metrics pending)

Description

In prepareTemplate currently, the invoice id in the returned object is set to the createdAt-time stamp. This is probably OK but could be problematic if invoices happen to be created simultaneously.

The number in question is a reference id for the invoice and is as such required to be digits only.

Two spontaneous solutions:

  1. Find a hash-generator without collisions that only generate numbers.
  2. Find some way to make sure that two invoices never get the same id, e.g. by making the creation of n invoices take n ms.

Contributor guide

Research direction
Research hash generators that output only digits, or implement a mechanism to ensure unique invoice IDs by combining timestamp with a counter or using a monotonically increasing sequence.
Tech stack
javascript
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85