Zannick/logic-graph

Better capacity/eviction policy for the segmented queue

Open

#97 opened on Jul 13, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (0 forks)auto 404
help wanted

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

With no fixed capacity and after removing the shrink_to_fit calls, we generate reports of the total capacity of each segment, and find that with our current AV2 test, the entire queue keeps a capacity of roughly 2-3x the capacity we asked for.

It may be beneficial to have a per-segment cap, such that we can better control the allocated capacity for each segment, especially since DoublePriorityQueue's underlying store does not support shrink_to_fit on the inner map, only on the lists of indexes. One idea is for the heap to perform a segment eviction if attempting to push or extend past a segment's capacity limit, which we'd set to maybe 1.5-2x the average we'd have with a full queue on all segments.

Contributor guide

Research direction
Study the current segmented queue implementation, particularly the capacity reporting and eviction. Then design and implement a per segment capacity limit with an eviction policy as described.
Tech stack
rust
Domain
game dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustData Structures
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45