Problems with the function "insert_left"

Open
#35 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
r

Research direction

Start by reproducing the supplied heatmap and dendrogram example with aplot 0.2.0, then compare the same call with 0.1.8 and 0.1.9. Trace the insert_left entry point and the limit handling that produces the zero_range error; done means the example combines successfully without the coercion warning or missing-value error.

Written by the indexing model from the issue text.

Description

When using the aplot package (version 0.2.0), the following error message appears when using the function "insert_left":

Error in if (zero_range(as.numeric(limits))) { : 
  missing value where TRUE/FALSE needed
In addition: Warning message:
In zero_range(as.numeric(limits)) : NAs introduced by coercion

We have a matrix to plot heatmap like this:

image

And then we use the following code to generate the cluster tree:

  dd <- dist(plotdata1, method = "euclidean")
  hc <- hclust(dd, method = "ward.D2")
  
  library(ggdendro)
  pa=ggdendrogram(hc,theme_dendro = F)+
    coord_flip()+
    scale_y_reverse()+
    theme_void()
image

Then the heatmap plot was plotted using the following code:

plotdata1 %>% ggplot(aes(x=condition,y=celltype))+
    geom_tile(aes(fill = value),color = tile_color)+
    scale_y_discrete(expand = c(0,0),position = "right")+
    scale_x_discrete(expand = c(0,0))+
    theme_bw()+
    theme(
      panel.grid = element_blank(),
      axis.title = element_blank(),
      axis.ticks.length = unit(0.15,"cm"),
      axis.text.y.right = element_text(size = 12,colour = "black"),
      axis.text.x.bottom = element_text(size = 12,colour = "black",angle = 0,hjust = 0.5)
    )
image

And if I want to combine the two plot, Error was occured:

>insert_left(pb,pa,width = relative_width)
Error in if (zero_range(as.numeric(limits))) { : 
  missing value where TRUE/FALSE needed
In addition: Warning message:
In zero_range(as.numeric(limits)) : NAs introduced by coercion

However, aplot (version 0.1.8) works fine whereas vesion 0.1.9 and 0.2.0 can't. So maybe it's necessary to solve this problem in the next vesion.

Dominant language
R
Stars
131
Forks
17
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from YuLab-SMU/aplot

All issues in YuLab-SMU/aplot

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.