Yalantis/uCrop

Toolbar text and icon color is not getting changed

Open

#467 opened on Nov 2, 2018

View on GitHub
 (8 comments) (3 reactions) (0 assignees)Java (11,748 stars) (2,134 forks)batch import
help wanted

Description

My app is using different color than white for the text and icons which appears at the top of crop screen. I've tried to change the color using theme color change in style but no success. Can you please guide me how can i change the color of text color which appears on Toolbar here is the code of manifest:

<activity
            android:name="com.yalantis.ucrop.UCropActivity"
            android:screenOrientation="portrait"
            android:theme="@style/uCropStyle"></activity>

here is the style i've applied to chage the color:

<style name="uCropStyle" parent="Theme.AppCompat.Light.NoActionBar">
        <item name="colorPrimaryDark">@color/black</item>
        <item name="colorAccent">@color/black</item>
        <item name="colorPrimary">@color/yellow</item>
        <item name="android:textColor">@color/black</item>
    </style>

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android themingReading XML layoutsBasic understanding of uCrop library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the toolbar layout in UCropActivity (likely within the library's res folder). Check if the theme attributes like `android:textColor` are actually applied to the toolbar's text and icons. Consider adding missing style attributes or providing a dedicated customization method. Review comments #467 for user attempts and maintainer suggestions.