Yalantis/uCrop

Please merge the latest pull request to master from Denko Smith and Jesse Li in 2018/4/18

Open

#450 opened on Aug 25, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (11,748 stars) (2,134 forks)batch import
help wanted

Description

Do you want to request a feature or report a bug? bug What is the current behavior? Exception occured. W/ExifInterface: Invalid image. java.io.IOException: Invalid marker: 89 at android.media.ExifInterface.getJpegAttributes(ExifInterface.java:1654) at android.media.ExifInterface.loadAttributes(ExifInterface.java:1360) at android.media.ExifInterface.<init>(ExifInterface.java:1063) at com.yalantis.ucrop.task.BitmapCropTask.crop(BitmapCropTask.java:131) at com.yalantis.ucrop.task.BitmapCropTask.doInBackground(BitmapCropTask.java:91) at com.yalantis.ucrop.task.BitmapCropTask.doInBackground(BitmapCropTask.java:30) at android.os.AsyncTask$2.call(AsyncTask.java:295) at java.util.concurrent.FutureTask.run(FutureTask.java:237) at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588) at java.lang.Thread.run(Thread.java:818) I/BitmapCropTask: Should crop: true

What is the expected behavior? uCrop not work.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. 【The pull request from Denko Smith and Jesse Li in 2018/4/18 had fixed.】！！！

Please attach any image files, URL and stack trace that can be used to reproduce the bug.

Which versions of uCrop, and which Android API versions are affected by this issue? Did this work in previous versions of uCrop? 2.2.2

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android developmentJavaExifInterface handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
First, locate the referenced pull request from Denko Smith and Jesse Li dated April 18, 2018 (likely in the repository's pull requests list). Review the changes to understand the fix for the ExifInterface Invalid marker bug. If the fix is valid, merge it into master. If the PR does not exist or is incomplete, investigate the ExifInterface issue in BitmapCropTask.java line 131 where the exception occurs, and consider handling invalid images gracefully.