strtoul in bif.l corrupts numbers larger than 2^32 on Windows
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 70/100
Research direction
Open bif.l at line 277 and inspect the conversion from the string value to uint64_t, paying particular attention to Windows integer widths. The issue is done when values larger than 0xFFFFFFFF are converted without corruption using the appropriate function.
Written by the indexing model from the issue text.
Description
On line 277 of bif.l, strtoul is used to convert the value from a string to uint64_t.
However on Windows, unsigned long is 32 bits not 64, so strtoul will silently corrupt any value greater than 0xFFFFFFFF to that value.
The correct function should be strtoull
- Dominant language
- C++
- Stars
- 64
- Forks
- 56
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Xilinx/bootgen
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
-
ATF handoff parameters are not set because execution address of all partitions, except FSBL, is zero Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
infiniflow/infinity#3502 ·