Xabaril/AspNetCore.Diagnostics.HealthChecks

Redis Health Check

Open

#750 opened on Mar 30, 2021

View on GitHub
 (3 comments) (8 reactions) (0 assignees)C# (3,776 stars) (737 forks)batch import
help wanted

Description

What would you like to be added:

I have already registered a singleton IConnectionMultiplexer to my IoC container and I would like my health check to use that instead.

// Func<IServiceProvider, IConnectionMultiplexer>
.AddRedis(sp => sp.GetRequiredService<IConnectionMultiplexer>())

Why is this needed:

To use the same connection as the application

Contributor guide

Tech stack
csharpredis
Domain
backendobservability
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#ASP.NET CoreRedis
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue requests a new overload of the AddRedis extension method that accepts an IConnectionMultiplexer parameter. The change is likely in the HealthChecks.Redis project, specifically in the RedisHealthCheckBuilderExtensions class. A new method should be created that uses the provided connection multiplexer instead of creating a new one, following the existing pattern for dependency injection. Review the current AddRedis method signatures and the HealthCheckBuilderExtensions file to understand the expected implementation.