Fix renderer docblock to reference the actual admin-bar nodes property

Open Beginner friendly
#16 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
82/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Quiet
Tech stack
wordpress
Domain
documentation

Research direction

Start by locating the renderer docblock and compare its property reference with the runtime Closure::bind path described in the issue. Update the documentation to refer to the admin bar instance's nodes property, leave the implementation unchanged, and verify the docblock no longer mentions _nodes.

Written by the indexing model from the issue text.

Description

documentation

The renderer docblock currently references $wp_admin_bar->_nodes[], but the runtime Closure::bind path accesses $this->nodes on the admin bar instance.

This is cosmetic, but it confused review of the WPCOM vendoring PR because Core's property is nodes, not _nodes.

Expected:

  • Update the renderer documentation to describe the actual property access.
  • Keep the implementation unchanged unless there is a separate reason to adjust it.
Dominant language
JavaScript
Stars
1
Forks
2
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from WordPress/wp-admin-bar-overflow

All issues in WordPress/wp-admin-bar-overflow

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.