WordPress/gutenberg

Native Image component includes outdated accessibility hint

Open

#45124 opened on Oct 19, 2022

View on GitHub
 (4 comments) (1 reaction) (0 assignees)JavaScript (9,607 stars) (3,893 forks)batch import
Good First IssueMobile App - i.e. Android or iOS[Block] Image[Block] Media & Text[Focus] Accessibility (a11y)[Type] Bug

Description

Description

When using a screen reader to navigate images in the native editor, an erroneous "Double tap and hold to edit" hint is read aloud. This discrepancy likely originates from https://github.com/WordPress/gutenberg/pull/40651.

Step-by-step reproduction instructions

  1. Add an Image or Media & Text block.
  2. Add media to the block.
  3. Enable Voice Over.
  4. Move focus to the image.

Expected behaviour

An accurate hint is read aloud, e.g. "Double tap to view larger."

Actual behaviour

An inaccurate hint is read aloud: "Double tap and hold to edit."

Screenshots or screen recording (optional)

https://user-images.githubusercontent.com/438664/196736195-90c75082-05e2-43dc-bdb4-19adf72e9b76.MP4

WordPress information

  • WordPress version: 6.1
  • Gutenberg version: 14.3.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Geologist

Device information

  • Device: iPhone SE
  • Operating system: iOS 16
  • WordPress app version: 1.84.0

Contributor guide

Tech stack
javascriptreactreact native
Domain
accessibilityfrontendmobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic familiarity with React Nativeknowledge of accessibility labels
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate PR #40651 that introduced the hint. Search the codebase for the string 'Double tap and hold to edit' likely in packages/components/src/image/index.native.js. The fix should update the hint to 'Double tap to view larger' or a similar appropriate string. Check if the hint is localized or defined as a constant.