WordPress/gutenberg

Allow the PanelColorSettings to be visible if no colors and but with children

Open

#12583 opened on Dec 4, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (9,607 stars) (3,893 forks)batch import
Good First IssueNeeds Dev[Package] Components[Type] Enhancement

Description

Is your feature request related to a problem? Please describe. With the PanelColorSettings, if the color prop is empty, the entire panel stops rendering. However, if PanelColorSettings has children, they won't show anymore also if the color prop is empty. I expect that the panel would still show up if it has children even with no color options available.

Describe the solution you'd like The PanelColorSettings should only hide if there are no color options AND no children. Right now is only checks the number of color options.

Describe alternatives you've considered I tried creating my own PanelColorSettings component to address this, but it uses a lot of unexposed / private components.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJavaScriptWordPress/Gutenberg basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Locate the PanelColorSettings component in the Gutenberg repository, likely in packages/components/src. Examine the component's render method where it currently returns null if there are no color settings. Modify the conditional to also check for the presence of children (props.children) and render the component if children exist, even if color settings are empty. Test the change by setting the colors prop to empty but passing children to ensure they render.