WhitestormJS/whs.js

Improve TextureModule

Open

#213 opened on Mar 22, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (425 forks)batch import
HacktoberfestMODULE

Repository metrics

Stars
 (6,070 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Some improvements can be made to TextureModule

  • allow setting more options on underlying texture from constructor (make sure includes every option three does)
    • minFilter and magFilter
  • allow passing in an "image object", i.e. (new THREE.TextureLoader()).load(imageUrl)
  • support data textures (or maybe make a DataTexture module - I have a wip for this)
  • support for a LoaderModule which can pass the resolved texture to the component, while managing loading status for all items used in it - see #215
Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.