Move `shared` tests to separate files
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- wasm
- Domain
- testing
Research direction
Start by reviewing the shared-memory test sections in test/core/memory.wast, test/core/imports.wast, and test/core/exports.wast, then compare the SIMD test file naming pattern. Done means shared memory tests are isolated in separately named files so engines can filter them without changing unrelated tests.
Written by the indexing model from the issue text.
Description
Currently, this threads proposal repo adds shared memory tests to existing test files in test/core: memory.wast, imports.wast, and exports.wast. For example:
https://github.com/WebAssembly/threads/blob/main/test/core/memory.wast#L9
However, not all wasm engines are expected to implement this threads proposal in its current form, even once it's standardized, some because of the nondeterminism, and some because of the effective dependency on Web Worker-style threads.
Would it make sense to move the tests for shared memory into separate files, so that engines which don't implement shared memories can easily filter them? This would be similar to the SIMD tests, which are all named simd_*.wast.
- Dominant language
- WebAssembly
- Stars
- 767
- Forks
- 54
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from WebAssembly/threads
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
WebAssembly/threads#254 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
WebAssembly/threads#253 · 6 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
WebAssembly/threads#245 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
WebAssembly/threads#240 ·
-
Branch renaming Open
Difficulty 1/5 Under an hour Newbie friendliness 20/100
WebAssembly/threads#237 ·
All issues in WebAssembly/threads
Similar issues
-
area:spec bug good first issue ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
low smart-contract Stellar Wave testing
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Web3Novalabs/Nevo#1376 · 3 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 60/100
github/gh-aw-mcpg#13748 ·