[spectec] Missing and wrong side conditions in the middle-end
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Quiet
- Tech stack
- wasm
- Domain
- compilers
Research direction
Start with spectec/src/middlend/sideconditions.ml at line 63 and inspect the existing MemE side condition alongside the handling of SliceE, UpdE, and ExtE. Check the middle-end backport context first; done means the MemE condition is corrected and the missing conditions are represented consistently.
Written by the indexing model from the issue text.
Description
I think for MemE the side condition about the sequence being non-empty is wrong (https://github.com/WebAssembly/spec/blob/main/spectec/src/middlend/sideconditions.ml#L63).
Also there should be side conditions for SliceE, UpdE and ExtE.
Opening this ticket just for the record. I think I'll do a PR with the flag controlling side conditions on functions, after we backport the middle-end from the WasmDSL repo.
- Dominant language
- WebAssembly
- Stars
- 3.5k
- Forks
- 540
- Avg merge
- 11h 12m
- Merged PRs (30d)
- 11
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from WebAssembly/spec
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
WebAssembly/spec#2245 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
WebAssembly/spec#2235 · 9 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
WebAssembly/spec#2155 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
WebAssembly/spec#2150 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
WebAssembly/spec#2130 · 5 comments ·
Maintainers usually reply within 1 day
All issues in WebAssembly/spec
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
dotnet/roslyn#85793 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
`type T = intrinsic` is read as a type name, and `type T = interface` as the `intrinsic` keywordOpen
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
sveltejs/acorn-typescript#152 ·
-
area:stdlib found-by:code-review kind:silent-wrong
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
InauguralSystems/EigenScript#1338 ·
Maintainers usually reply within 1 day
-
better error message generics low priority
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day