Warzone2100/warzone2100

Inconsistent use of upper and lower case letters in stats and api.

Open

#1,794 opened on Apr 29, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (610 forks)auto 404
Buggood first issuewzapi

Repository metrics

Stars
 (3,886 stars)
PR merge metrics
 (PR metrics pending)

Description

data/base/stats/weapons.json:           "firePause": 7,
src/stats.cpp:              psStats->base.firePause = ini.value("firePause").toUInt();
src/wzapi.cpp:                      weap["FirePause"] = psStats->base.firePause;

This applies to almost all parameters. Attempting to change the styling within the engine will require changing all scripts.

There is a separate parameter thresholds it turns into RankThresholds

Contributor guide

Research direction
Identify all parameters in data files and source code that have inconsistent casing. Decide on a consistent naming convention (e.g., all lowercase or camelCase) and update both the data files and source code accordingly.
Tech stack
c
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60