Warzone2100/warzone2100

Factory assigned to commander ignores command limits

Open

#1,600 opened on Mar 9, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (610 forks)auto 404
Buggood first issue

Repository metrics

Stars
 (3,886 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug Factories assigned to a commander will continue to produce units even once the command limit is reached. "Production complete. Assigned to commander" is announced, but the unit is left unassigned and the factory then produces another unit.

To Reproduce Steps to reproduce the behavior:

  1. Produce a commander, assign it to a factory
  2. Produce units from assigned factory
  3. Observe that n+1... units are produced, unassigned. Continues indefinitely if production is looped.

Expected behavior n+1 units are produced, with last unit assigned to commander but remains inactive. No further units are produced.

Your System: Kubutunu 20.04 Warzon 4.0.0 beta 1

Contributor guide

Research direction
Investigate the unit production logic in the command system to find where the command limit check is bypassed when a factory is assigned to a commander.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65