Warzone2100/warzone2100

Units will display a yellow HP bar and emit smoke although their HP is above 75%

Open

#1,040 opened on Jul 16, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (610 forks)auto 404
Buggood first issue

Repository metrics

Stars
 (3,886 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug Units will display a yellow HP bar and emit smoke although their HP is above 75%.

To Reproduce Steps to reproduce the behavior:

  1. Start a skirmish game
  2. Produce a large army of decently healthed units (e.g. not viper wheels, these may have too little HP to recreate this bug)
  3. Attack the enemy
  4. Retreat
  5. Some units may have yellow health bars and are above 75% health.

Expected behavior Units should not display smoke or a yellow health bar if their HP is not enough to retreat at medium damage.

Screenshots or Videos https://i.imgur.com/ucykiAt.png In this image, the unit has 204/270 HP, which is 75.555555% health. This is above 75% so it does not retreat despite being set to Retreat At Medium Damage, however it is enough to display yellow health and smoke.

(If it was retreating due to medium damage, it would de-assign itself from group 1)

Your System:

  • OS: Linux
  • Game version: 3.4.0

Additional context

  • This issue may also apply to units at red (heavy) damage. For example the units may display red health and not retreat.

Contributor guide

Research direction
Investigate the code that determines health bar color and smoke emission based on HP percentage. The bug suggests the threshold between green and yellow is off. Check the threshold constants and ensure that when HP > 75%, the bar is green and no smoke. Also check the retreat logic to ensure consistency.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70