Vincit/objection.js

Add a way to modify the "on clause" when using joinRelated.

Open

#1,975 opened on Jan 19, 2021

View on GitHub
 (4 comments) (1 reaction) (0 assignees)JavaScript (7,146 stars) (663 forks)batch import
enhancementhelp wanted

Description

Currently this is only possible using the "raw" join methods inherited from knex.

Contributor guide

Tech stack
javascriptnodejssql
Domain
backenddatabaseapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of Objection.jsUnderstanding of SQL joins
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the existing `joinRelated` method in the query builder (likely in `lib/queryBuilder/JoinBuilder.js`). Review how the 'on clause' is currently constructed and how Knex's raw join methods allow customization. Propose an API extension that passes a callback to modify the join condition, similar to how Knex's `join` works. Check if there are any related discussions or linked PRs in the issue comments.