VictorTaelin/WebMonkeys

Setters don't set

Open

#8 opened on Aug 28, 2016

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (1,163 stars) (57 forks)batch import
bughelp wanted

Description

First off, awesome work on this project! It really looks great.

I am running a modified version of the squareNumbers example (I have tried this on the original code as well):

const monkey = WebMonkeys()

monkey.set('res', [1, 2, 3, 4, 5])
monkey.work(5, 'res(i) := res(i) * res(i);')

console.log(monkey.get('res'))

But the final output seems to be the original 'res' array instead of the squares.

This happens with all of the examples. None of the 'set' statements seem to work for me.

Contributor guide

Tech stack
javascript
Domain
api
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptFamiliarity with WebMonkeys API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Start by examining the set method in the WebMonkeys library's source code (likely in src/WebMonkeys.js). Compare with the get method to see if set correctly stores data. Check if there is any issue with the array flattening or type conversion. Also review the comments in the issue for any hints from maintainers. A simple test script can be run to replicate the bug and identify whether the issue is in set or in the GPU work function.
Setters don't set · VictorTaelin/WebMonkeys#8 | Good First Issue