VSCodeVim/Vim

I have overloaded cursorStartPosition to be too many different things.

Open

#805 opened on Sep 27, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (1,271 forks)batch import
help wantedkind/refactorsize/L

Repository metrics

Stars
 (12,664 stars)
PR merge metrics
 (Avg merge 9d 13h) (7 merged PRs in 30d)

Description

Currently cursorStartPosition and cursorPosition can mean both "the start and end of the current selection" and "the range over which to apply an operator".

These are actually totally different! It's especially bad when you apply an operator and then suddenly you lose the tracked position of the cursor.

Move "the range over which to apply an operator" into a new field on RecordedState and use that instead of cursorStartPosition and cursorPosition. Continue using cursorStartPosition and cursorPosition for selections and cursor locations.

My current problem is running ci( on |(abcd), which promptly forgets the position of the cursor and can't (because of the overloading) figure out where to place it.

Contributor guide

Research direction
Understand the current usage of cursorStartPosition and cursorPosition in the codebase, identify all places where operator range is mixed with selection tracking, then introduce a new field on RecordedState to hold the operator range and update all related logic accordingly.
Tech stack
typescript
Domain
tooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50