VSCodeVim/Vim

I have overloaded cursorStartPosition to be too many different things.

Open

#805 opened on Sep 27, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (12,664 stars) (1,271 forks)batch import
help wantedkind/refactorsize/L

Description

Currently cursorStartPosition and cursorPosition can mean both "the start and end of the current selection" and "the range over which to apply an operator".

These are actually totally different! It's especially bad when you apply an operator and then suddenly you lose the tracked position of the cursor.

Move "the range over which to apply an operator" into a new field on RecordedState and use that instead of cursorStartPosition and cursorPosition. Continue using cursorStartPosition and cursorPosition for selections and cursor locations.

My current problem is running ci( on |(abcd), which promptly forgets the position of the cursor and can't (because of the overloading) figure out where to place it.

Contributor guide

Tech stack
typescript
Domain
toolingdeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptVim extension internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the RecordedState structure in the VSCodeVim codebase. Identify all usages of cursorStartPosition and cursorPosition, and determine which belong to the operator range versus selection. Create a new field in RecordedState to hold the operator range, and update relevant code to use it. Ensure that operator commands function correctly without interfering with cursor selection tracking.