VSCodeVim/Vim

Vertical cursor moving for CJK lines

Open

#4,096 opened on Sep 24, 2019

View on GitHub
 (2 comments) (2 reactions) (0 assignees)TypeScript (1,271 forks)batch import
area/non-latin-charactershelp wantedkind/bug

Repository metrics

Stars
 (12,664 stars)
PR merge metrics
 (Avg merge 9d 13h) (7 merged PRs in 30d)

Description

Describe the bug Vertical cursor moving is incorrect when lines contain CJK characters even using monospace CJK fonts.

02 03

To Reproduce

  1. Type CJK characters.
  2. Move cursor with 'j' 'k' or arrow keys in NORMAL, INSERT, VISUAL modes.

Expected behavior VSCODE fixed this issue, but VSCodeVim still have one. https://github.com/microsoft/vscode/pull/44259

Behave same as default VSCODE expected.

00 01

Contributor guide

Research direction
Study the VS Code PR #44259 fix for CJK cursor movement, then update the extension's cursor logic for vertical movement to handle CJK characters correctly.
Tech stack
typescript
Domain
developer experiencefrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70