VSCodeVim/Vim

Vertical cursor moving for CJK lines

Open

#4,096 opened on Sep 24, 2019

View on GitHub
 (2 comments) (2 reactions) (0 assignees)TypeScript (12,664 stars) (1,271 forks)batch import
area/non-latin-charactershelp wantedkind/bug

Description

Describe the bug Vertical cursor moving is incorrect when lines contain CJK characters even using monospace CJK fonts.

02 03

To Reproduce

  1. Type CJK characters.
  2. Move cursor with 'j' 'k' or arrow keys in NORMAL, INSERT, VISUAL modes.

Expected behavior VSCODE fixed this issue, but VSCodeVim still have one. https://github.com/microsoft/vscode/pull/44259

Behave same as default VSCODE expected.

00 01

Contributor guide

Tech stack
typescript
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Vim cursor movementCJK character width handlingVSCodeVim extension structureTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
This bug involves incorrect vertical cursor movement (j/k) for lines containing CJK characters. The expected behavior is to match VS Code's handling after PR #44259 (https://github.com/microsoft/vscode/pull/44259). The fix likely requires modifications to the cursor movement logic in the Vim extension, possibly in files like 'src/actions/motion.ts' or 'src/common/motion/position.ts', to properly account for character width when calculating cursor positions. Investigate how VS Code's TextEditor selection computes cursor positions with double width characters and replicate that behavior in VSCodeVim.