VSCodeVim/Vim

"go to definition", etc go to the right line, but wrong column

Open

#3,102 opened on Oct 5, 2018

View on GitHub
 (10 comments) (0 reactions) (0 assignees)TypeScript (1,271 forks)batch import
help wantedkind/bug

Repository metrics

Stars
 (12,664 stars)
PR merge metrics
 (Avg merge 9d 13h) (7 merged PRs in 30d)

Description

Describe the bug using "go to definition" doesn't seem to update the column - it keeps the previous column.

To Reproduce Steps to reproduce the behavior:

  1. Click on a function call
  2. Right-click
  3. "go to definition"
  4. Notice the column LOOKS correct
  5. Move cursor using hjkl
  6. Notice the cursor column jumps to where you were before the "go-to-definition", but on the correct line.

Expected behavior The column is in-sync just like the row

Screenshots

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 0.16.6
  • VSCode version: 1.27.2
  • OS: Linux - Kubuntu current LTS

Additional context None

Contributor guide

Research direction
Investigate how VSCodeVim updates the cursor column after executing 'go to definition'. Look at the handler for the 'go to definition' command, and trace how the cursor position is set. The issue suggests that only the line is updated, not the column. Check the VSCode API calls like `vscode.commands.executeCommand('editor.action.goToDefinition')` and subsequent cursor positioning logic in the extension.
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65