VSCodeVim/Vim

Editor is undefined

Open

#3033 opened on Sep 7, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (12,664 stars) (1,271 forks)batch import
good first issuehelp wanted

Description

Describe the bug The property 'editor' can be undefined (see Screenshots section).

To Reproduce Steps to reproduce the behavior:

  1. Start VSCode
  2. Check Breakpoints > Promise Rejects and Breakpoints > Uncaught Exceptions
  3. Start my extension in debug mode (Debugger > Launch client). I believe, that can be reproduced with any extension, though it happened to me during development of mine plugin.
  4. If any file is opened after start, close all of them and start again.

Expected behavior The absence of the error.

Screenshots debugger

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 0.16.3
  • VSCode version: 1.27.1
  • OS: Ubuntu 16.04

Additional context

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic TypeScriptVSCode extension API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the code at src/mode/modeHandler.ts line 1324 where `editor` is accessed without a null check. Review the context to understand when `editor` could be undefined, such as when no file is open. Add a guard clause to handle the undefined case, perhaps by returning early or providing a fallback. Test the fix by starting VSCode with no files open and triggering the debug steps described in the issue.