VSCodeVim/Vim

`j` and `k` do not account for tab size

Open

#2,458 opened on Mar 20, 2018

View on GitHub
 (10 comments) (21 reactions) (1 assignee)TypeScript (12,664 stars) (1,271 forks)batch import
area/motionhelp wantedkind/bug

Description

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG What happened: Note: The second line start with a tab indent. Default(disabled vim plugin): foo enable vim plugin:(pressing gj can solve, but what about insert and visual mode) foo2 or Insert mode: foo3 Visual mode: bar2

What did you expect to happen: Like vscode default show or native vim. How to reproduce it (as minimally and precisely as possible):

Environment:

  • Extension (VsCodeVim) version:0.11.2
  • VSCode version:1.12.1
  • OS version:4.15.9-1-ARCH

Contributor guide

Tech stack
typescript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptVim motions knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the code handling `j` and `k` movements in the VSCodeVim extension. Look at the cursor move functions, particularly how they handle screen lines versus logical lines, and how tab size is accounted for. Check if tab size is used elsewhere, e.g., in the `gj` and `gk` implementations. Also review the test cases for motions to ensure new behavior is tested. Consider both normal, insert, and visual modes.