VSCodeVim/Vim

[Bug] Custom escape binding won't trigger statusBarColorControl

Open

#2251 opened on Dec 29, 2017

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (12,664 stars) (1,271 forks)batch import
help wantedkind/bug

Description

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

What happened: When i'm using my jj keybind in insert mode the status bar's color isn't changing. The mode changed to normal mode.

When i'm using my escape key in insert mode the status bar's color is changing properly.

What did you expect to happen: When using the jj keybind to go back to normal mode, expect the status bar's color to change like when i'm using the standard escape key.

How to reproduce it (as minimally and precisely as possible): Use my color settings, press i to go in insert mode and then press jj. Notice the status bar's color.

These are in my settings.json "vim.insertModeKeyBindings": [ { "before": [ "j", "j" ], "after": [ "" ] } ], "vim.statusBarColorControl": true, "vim.statusBarColors": { "normal": "#005f5f", "insert": "#5f0000", "visual": "#5f00af", "visualline": "#005f87", "visualblock": "#86592d", "replace": "#000000" },

Environment: Windows 8 vscode 1.19.1 vscodevim 0.10.6

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript knowledgeVSCode extension APIEvent handling in Vim extension
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the event flow when a custom key binding (like 'jj') triggers normal mode. Compare with the direct <Esc> key event to see why the status bar color update is not fired. Look at the mode change handler and the status bar color control logic, possibly in files like `src/mode/modeHandler.ts` or `src/statusBar.ts`. Check if the custom key binding bypasses the normal mode change event that triggers the color update. Also, review the `vim.insertModeKeyBindings` configuration parsing.