VSCodeVim/Vim

'Find' in VISUAL MODE reverts to first occurrence when looping through them

Open

#2238 opened on Dec 22, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (12,664 stars) (1,271 forks)batch import
area/searchhelp wantedkind/bug

Description

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Environment:

  • VSCode Version: 1.19.0
  • VsCodeVim Version: Sunny Seattle
  • OS: Ubuntu 17.10

What happened: When navigating through occurrences of Find in file that was initiated with VISUAL MODE, cursor goes back to first occurrence whenever find popup is closed.

What did you expect to happen: Cursor should stay at current occurrence upon exiting Find in file.

How to reproduce it:

  1. Select chunk of text (e.g. const) with multiple occurrences in file with v (mode switches to VISUAL).
  2. Press Ctrl+f. Find popup appears with const in it.
  3. Navigate through occurrences with Enter.
  4. Press Esc on desired occurrence to close find popup and expect the cursor to stay on this occurrence.
  5. See the cursor going back to first occurrence where it was in step 1.
  6. Cry.

Example screenshot

Here Find started at first const, I've navigated to third one with Enter. When I press Esc to exit Find, cursor goes back to first const though should stay at third one.

Contributor guide

Tech stack
typescript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptVSCode extension developmentVim visual mode basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the visual mode find logic in the VSCodeVim extension. Look for how the cursor position is reset when the find popup closes. The bug suggests that the cursor is being reset to the original occurrence instead of staying on the selected occurrence. Check the event handlers for the find widget and any state management related to visual mode search. The issue has 4 comments; review them for any hints. The codebase is written in TypeScript, focusing on the src/ directory.