VSCodeVim/Vim

Toggle vim mode between two VSCode windows is broken

Open

#2198 opened on Dec 6, 2017

View on GitHub
 (1 comment) (9 reactions) (0 assignees)TypeScript (12,664 stars) (1,271 forks)batch import
help wantedkind/bugstatus/by-design

Description

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

BUG REPORT

Environment:

  • VSCode Version: 1.18.1
  • VsCodeVim Version: 0.10.3
  • OS: Linux (Ubuntu)

What happened:

When I toggle vim mode off / on in one VSCode window it somehow affects the other one. It is disables vim mode in the active windows but for the other it remains enabled (expected), however it is in somewhere in between state, neither enabled or disabled - i.e. broken.

{
  "command": "toggleVim",
  "key": "ctrl+k ctrl+v"
}

What did you expect to happen: That toggleVim function will disable and enable vim mode in active window and will not affect other windows if they are.

How to reproduce it:

  1. Open one project in one VSCode window
  2. Open second project in new VSCode window (second)
  3. Focus first window
  4. ctrl+shift+p type: >Toggle vim mode, press enter
  5. Vim-mode should be disabled in first VSCode window
  6. Vim-mode broken in second VSCode window

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of VSCode extension API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the toggleVim command implementation in VSCodeVim. Look for how the extension manages state across multiple VSCode windows. Check the source code for any global variables or settings that could cause side effects. Consider if there is a missing isolation of state per window. The fix likely involves ensuring that toggling vim mode only affects the active window.