VSCodeVim/Vim

emmet balance action does not work with `s`

Open

#2183 opened on Nov 29, 2017

View on GitHub
 (1 comment) (2 reactions) (0 assignees)TypeScript (12,664 stars) (1,271 forks)batch import
help wantedkind/bug

Description

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG

Environment:

  • VSCode Version: 1.18.1
  • VsCodeVim Version: 0.10.5
  • OS: macOS 10.12.6

What happened:

  1. Open any html file
  2. Cmd + Shift + P -> Emmet: Balance (outward)
  3. s
  4. The selection is not deleted and VS Code ends in insert mode.

What did you expect to happen:

The selection deleted and VS Code ends in insert mode.

emmet

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic understanding of vim modes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue involves the emmet balance command not working after pressing 's'. Look at the emmet integration code in the extension, likely in files related to command handling or emmet actions. Check if the 's' key is being intercepted incorrectly. The fix may involve adjusting the keybinding or mode handling.