VSCodeVim/Vim

Select All Occurrences returns cursor to starting mode.

Open

#2042 opened on Sep 27, 2017

View on GitHub
 (16 comments) (25 reactions) (0 assignees)TypeScript (12,664 stars) (1,271 forks)batch import
area/multicursorarea/selectionhelp wantedkind/bug

Description

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Environment:

  • VSCode Version: 1.16.1
  • VsCodeVim Version: 0.10.1
  • OS: macOS Sierra (10.12.6)

What happened: VSCode Select All Occurrences command (⇧⌘L on macOS) was performed on a selection. A cursor was created for each matching instance of the current word, but the cursors did not stay in Visual mode.

What did you expect to happen: All matching instances of the word should be selected and remain in Visual mode.

How to reproduce it: Create a file with multiple matching instances and perform the Select All Occurrences command.

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Vim knowledgeVS Code extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how the VSCodeVim extension handles Visual mode when the 'Select All Occurrences' command (editor.action.selectHighlights) is invoked. Look at the extension's mode handling in src/mode/mode.ts and the command mapping in src/actions/commands/actions.ts. Check if a cursor state reset occurs after the command. Consider testing with the current VS Code API.