Incorrect mkNumericExpr implementation

Open

#280 opened on May 22, 2025 0 comments 0 reactions 1 assignee View on GitHub

@CaelmBleidd is already working on this.

Since May 22, 2025.

Assessment

This issue has not been assessed yet.

Description

There are several rules for variables transformation into a number. For now, only few of them are supported.

    7.1.4 ToNumber ( argument )
    
    1. If argument is a Number, return argument.
    **2. If argument is either a Symbol or a BigInt, throw a TypeError exception.**
    3. If argument is undefined, return NaN.
    4. If argument is either null or false, return +0𝔽.
    5. If argument is true, return 1𝔽.
    **6. If argument is a String, return StringToNumber(argument).**
    7. Assert: argument is an Object.
    **8. Let primValue be ToPrimitive(argument, "number").**
    **9. Assert: primValue is not an Object.**
    **10. Return ToNumber(primValue).**

Now for objects it always returns NaN which is incorrect, for example, for [0] or objects with toString returning a string with a number inside.

Dominant language: Kotlin
Stars: 33
Forks: 27
Avg merge: 4d 3h
Merged PRs (30d): 15

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

No test covers the claim that only the last command's state is checked Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

johanhaleby/occurrent#1120 · Opened Sep 23, 2026
TOML `rename` is not applied to a type inside `Box<T>` (Swift, Kotlin, Python) Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

mozilla/uniffi-rs#3006 · Opened Sep 23, 2026
2 rename bugs Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

yairm210/Unciv#15634 · 1 comment · Opened Sep 23, 2026
Hide camera-based functionality if the device does not have a camera Open

Difficulty 2/5 1-3 hours Newbie friendliness 68/100

ankidroid/Anki-Android#21999 · Opened Sep 22, 2026
libzkp.so in jniLibs/x86_64 is a 32-bit ELF binary instead of 64-bit Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

openwallet-foundation/multipaz#2028 · Opened Sep 22, 2026

More Kotlin issues