UnicornsOnLSD/finamp

Setting to hide download / delete button

Open

#559 opened on Dec 18, 2023

View on GitHub
 (6 comments) (0 reactions) (1 assignee)Dart (3,934 stars) (268 forks)batch import
easy fixgood first issueredesign-beta

Description

I have the app set up for my kids to use, and I have the library downloaded for offline use. As they stumble around, it happens that they start deleting stuff. Could there be a setting to disable the download UI? I.e offline mode etc would still work, the app just wouldn't show the ability to download or delete downloaded files anywhere.

If there's interest, I should be able to look into opening a PR for it. I've flutted before.

Contributor guide

Tech stack
dartflutter
Domain
mobilefrontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with FlutterUnderstanding of Finamp's settings system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look for the settings model in the Finamp codebase, likely in a file like 'settings.dart' or similar. Identify where download and delete buttons are rendered in the UI (e.g., in album or track views). Then implement a new boolean setting to hide these buttons, and conditionally wrap the button widgets with a visibility check. Ensure the setting is persisted and accessible from the settings screen.