selectedItem property of Select$ChangeEventParameters should not be optional
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- tooling
Research direction
Start at the Select$ChangeEventParameters type declaration and compare its selectedItem parameter with the UI5 API reference linked in the issue. Update the type so the shown onChangeDimensionType example no longer reports selectedItem as possibly undefined, then run the repository's relevant type checks or tests.
Written by the indexing model from the issue text.
Description
Describe the bug
public async onChangeDimensionType(event: sap.m.Select$ChangeEvent) {
const selectedItem = event.getParameter("selectedItem");
}
TS tells me that selectedItem might be undefined, which is wrong.
Expected behavior
Should return a selected item, as defined by the UI5 API reference.
- Dominant language
- TypeScript
- Stars
- 213
- Forks
- 35
- Avg merge
- 37m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from UI5/typescript
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
UI5/typescript#625 · 4 comments ·
-
Dependency Dashboard Open
Difficulty 5/5 Over a week Newbie friendliness 15/100
UI5/typescript#587 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
UI5/typescript#532 ·
-
enhancement ts-interface-generator
Difficulty 5/5 Over a week Newbie friendliness 30/100
UI5/typescript#524 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
UI5/typescript#520 · 3 comments ·
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100