PvP Ranks extra honor

Open

#16 opened on Jul 23, 2019 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 45/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: cpp
Domain: game-dev

Research direction

Search the C++ sources for the PvP Ranks calculation shown in the issue and compare it with commit c840b87d24ba21f1c06127f0d2ce991afe0de7b2. Trace how the extra-honor rate flows into honor_f and the final integer value, then verify that PvP rank honor retains the custom adjustment without changing unrelated behavior.

Written by the indexing model from the issue text.

Description

PvP Ranks calls

honor *= 1 + sWorld->getRate(RATE_PVP_RANK_EXTRA_HONOR)*(((float)rank_diff) / 10.0f);

but then

honor = int32(honor_f);

so the custom extra honor gets lost.

honor_f should probably be changed instead.

https://github.com/TrinityCore/TrinityCoreCustomChanges/commit/c840b87d24ba21f1c06127f0d2ce991afe0de7b2#diff-5589ee47b3a7ad220cff105a8fe7eac3R6854

Dominant language: C++
Stars: 83
Forks: 58
PR merge metrics: No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

rate_limit_sni_expiry AuTest is flaky: the holder races FIFO removal Open

AuTest Bug Tests

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

apache/trafficserver#13714 · Opened Sep 22, 2026
[CI] Nightly Clang build broken: ToJsonFunction no longer binds to registerFunction Open

bug build

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

facebookincubator/velox#19143 · Opened Sep 22, 2026
Misc. bug: Vulkan: ggml_backend_vk_get_device_memory reports free > total when the driver's heapBudget exceeds heap size (Intel iGPU, Windows); downstream consumers underflow Open

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

ggml-org/llama.cpp#29277 · Opened Sep 22, 2026
tt_metal/hw/inc/internal/tt-2xx/quasar/overlay/xcustom_test.hpp needs reimplementing Open

Difficulty 2/5 1-3 hours Newbie friendliness 68/100

tenstorrent/tt-metal#57393 · 1 comment · Opened Sep 22, 2026
Ford-Fulkerson entry point sizes the graph by argument count, not by vertex id range, so it crashes on any vertex id >= args.length Open

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

objectionary/eo-graphs#74 · Opened Sep 22, 2026

More C++ issues