AllocatorVisualizer could/should implement Default

Open Beginner friendly
#103 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
computer-graphics

Research direction

Inspect the AllocatorVisualizer definitions for the Vulkan and DX12 backends and their argument-free new() constructors. Implement Default consistently for both, then run Clippy to verify the new_without_default lint is resolved and the existing test suite still passes.

Written by the indexing model from the issue text.

Description

Hello,
First of all, thank you for the excellent library.

The AllocatorVisualizer struct (both DX12 and Vulkan) are created using the new() function, which notably has no arguments. One might expect it to implement Default for this reason, but it does not.
There's a clippy lint for this: https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
The Rust API guidelines recommend the same: https://rust-lang.github.io/api-guidelines/interoperability.html

Dominant language
Rust
Stars
497
Forks
82
Avg merge
18d 17h
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Traverse-Research/gpu-allocator

All issues in Traverse-Research/gpu-allocator

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.