TraceMachina/nativelink

Worker connection failures on startup shouldn't raise errors

Open

#615 opened on Jan 17, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Rust (222 forks)auto 404
buggood first issue

Repository metrics

Stars
 (1,557 stars)
PR merge metrics
 (PR metrics pending)

Description

At the moment we raise errors when the worker can't find the scheduler:

https://github.com/TraceMachina/nativelink/actions/runs/7558646440/job/20580653217?pr=614#step:9:197

This might lead to issues when running health and readiness checks and readiness checks in K8s. We should find a solution that integrates better with the K8s scheduler.

Contributor guide

Research direction
Examine the worker's startup failure handling in the codebase, understand how the scheduler connection is established, and propose an approach to defer errors or integrate with Kubernetes health probes.
Tech stack
rust
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75