Tichau/FileConverter

Closing the window while converting is running does't warn or abort.

Open

#361 opened on Jan 24, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (14,357 stars) (871 forks)batch import
good first issuenew feature

Description

Minor issue:

Usually closing the window either warns or direly stops a program, however it seems that ffmpeg.exe keeps running, no longer attached to any program and therefore there is no way to stop it. Basically one must wait or kill ffmpeg.exe manually.

Contributor guide

Tech stack
csharp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic C#Windows Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Examine the main form's FormClosing event. The conversion likely spawns ffmpeg.exe as a child process. Check if a conversion is active; if so, prompt the user or abort the process. Look at the conversion manager class for process references. No existing PRs or comments.