ThreeMammals/Ocelot

HTTP status 499 seems inappropriate when gateway times out waiting on server

Open

#1687 opened on Aug 29, 2023

View on GitHub
 (9 comments) (5 reactions) (1 assignee)C# (8,137 stars) (1,617 forks)batch import
bugdocumentationgood first issuehelp wantedproposalquestion

Description

Expected Behavior / New Feature

When the gateway (Ocelot) times out waiting for the server to respond, I would expect an HTTP error code of 504, not 499. I wouldn't ever expect a 499 to be returned to the client -- that seems like an error that would just end up in the logs indicating that the client cancelled the request.

Actual Behavior / Motivation for New Feature

With the current behavior, a 499 is returned when Ocelot times out waiting for the server to respond.

Specifications

  • Version: 17.0.0

Contributor guide

Tech stack
csharprest api
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of HTTP status codesFamiliarity with .NET and Ocelot basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Locate the source of the 499 status code in Ocelot's timeout handling, likely in the 'Ocelot.Requester' or 'Ocelot.Middleware' namespaces. Check the issue comments for any additional context. The fix involves replacing 499 with 504 in the relevant code path. Ensure the change aligns with HTTP standards.