ThreeMammals/Ocelot

HTTP status 499 seems inappropriate when gateway times out waiting on server

Open

#1,687 opened on Aug 29, 2023

View on GitHub
 (10 comments) (5 reactions) (1 assignee)C# (1,617 forks)batch import
bugdocumentationgood first issuehelp wantedproposalquestion

Repository metrics

Stars
 (8,137 stars)
PR merge metrics
 (Avg merge 44d 17h) (6 merged PRs in 30d)

Description

Expected Behavior / New Feature

When the gateway (Ocelot) times out waiting for the server to respond, I would expect an HTTP error code of 504, not 499. I wouldn't ever expect a 499 to be returned to the client -- that seems like an error that would just end up in the logs indicating that the client cancelled the request.

Actual Behavior / Motivation for New Feature

With the current behavior, a 499 is returned when Ocelot times out waiting for the server to respond.

Specifications

  • Version: 17.0.0

Contributor guide

Research direction
Locate the code in Ocelot that returns HTTP status 499 when a gateway timeout occurs, and change it to return 504 (Gateway Timeout) instead. Update any associated tests.
Tech stack
csharp
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
.NETHTTP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40