TheWidlarzGroup/react-native-video

[BUG]: `resizeMode` prop is not implemented on web

Open

#4,297 opened on Nov 21, 2024

View on GitHub
 (7 comments) (2 reactions) (0 assignees)Kotlin (3,027 forks)batch import
AcceptedMissing ReproNewer Version AvailablePlatform: WebV6bugdifficulty: easygood first issuepriority: lowtriaged

Repository metrics

Stars
 (7,677 stars)
PR merge metrics
 (Avg merge 2d 3h) (11 merged PRs in 30d)

Description

What happened?

The object-fit style property of the video element in Video.web.tsx should respect the resizeMode prop.

Currently the resizeMode prop is not implemented on web, so setting it (e.g. to "cover") has no effect on how the video is displayed.

Steps to reproduce

  1. Set resizeMode to "cover" on a Video component.
  2. Run the app on web and observe the video in a browser.
  3. Notice that the video does not respect the resizeMode value.

Reproduction repository

No response

react-native-video version

6.8.0

react-native version

No response

react-native-nitro-modules version

No response

Platforms

Web

OS version

Chrome

Device

Real device

Architecture

Old Architecture

Expo

No response

Last working version

No response

Media / source type

No response

Contributor guide

Research direction
Investigate the Video.web.tsx component and map the resizeMode prop to the CSS object fit property on the video element.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactReact NativeCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70