TheWidlarzGroup/react-native-video

Built-in <Video /> controls showing even when controls prop is set to false

Closed

#3,129 opened on May 25, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Kotlin (3,027 forks)batch import
6.x.xPlatform: WindowsV6good first issuehelp wanted

Repository metrics

Stars
 (7,677 stars)
PR merge metrics
 (Avg merge 2d 3h) (11 merged PRs in 30d)

Description

Bug

I'm trying to implement custom controls for the video, but the built in controls don't go away.

Platform

React Native Windows Which player are you experiencing the problem on: Windows UWP

Environment info

React native info output:

System:
    OS: Windows 10 10.0.22621
    CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
    Memory: 16.89 GB / 31.92 GB
  Binaries:
    Node: 18.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 9.5.1 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK: Not Found
    Windows SDK:
      AllowDevelopmentWithoutDevLicense: Enabled
      Versions: 10.0.18362.0, 10.0.19041.0, 10.0.22000.0
  IDEs:
    Android Studio: Not Found
    Visual Studio: 17.5.33627.172 (Visual Studio Enterprise 2022), 16.11.33529.622 (Visual Studio Enterprise 2019)
  Languages:
    Java: Not Found
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0
    react-native: 0.70.6 => 0.70.6
    react-native-windows: 0.70.10 => 0.70.10
  npmGlobalPackages:
    *react-native*: Not Found

"react-native": "0.70.6", "react-native-video": "^5.2.1", "react-native-windows": "0.70.10",

Steps To Reproduce

  1. Set controls prop on Video to false
  2. Observe the controls still appear

Expected behaviour

  1. Set controls prop on Video to false
  2. Controls hidden

Reproducible sample code

<Video onTouchStart={summonControls} style={styles.backgroundVideo} source={source} controls={false} paused={!isPlaying} muted={isMuted} volume={volume} onProgress={onProgress} onLoad={onPlayerLoad} onEnd={onEnd} onError={onPlayerError} onAudioBecomingNoisy={() => setIsPlaying(false)} poster={poster} fullscreen={isFullScreen} resizeMode={resizeMode} ref={_player} textTracks={textTracks} selectedTextTrack={isCCOn ? selectedTextTrack : undefined} disableFullscreen={true} {...otherProps} />

Contributor guide

Research direction
Investigate the Windows native implementation of the Video component in react native video. The controls prop should be passed to the UWP MediaPlayerElement's AreTransportControlsEnabled property. Look at the native module code, likely in the RNWVideoView or similar, to see how the controls prop is mapped. The fix is to ensure that when controls={false} is passed, the transport controls are disabled. No linked PRs or comments exist yet.
Tech stack
react nativejavascript
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React NativeJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60