TheSpyder/rescript-webapi

Add a test that guarantees the blob and file types are compatible everywhere they can be used

Open

#99 opened on Mar 9, 2022

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)ReScript (38 forks)github user discovery
good first issuehelp wanted

Repository metrics

Stars
 (159 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

#97 happened because there aren't tests that ensure data returned from fetch APIs can be used by other blob and file APIs. We should write tests for this (remember we don't need executable tests, just code that won't compile if the types aren't compatible).

Contributor guide

Research direction
Review existing Blob and File type definitions in the ReScript bindings, then write type level tests that verify the returned types from fetch APIs are compatible with functions expecting Blob or File. The tests should be non executable but cause compile errors if types are incompatible.
Tech stack
None
Domain
frontend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75