TheSpyder/rescript-webapi

Remove trailing _ from method and parameter names

Open

#29 opened on Sep 23, 2021

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)ReScript (38 forks)github user discovery
good first issue

Repository metrics

Stars
 (159 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In many cases, ReScript syntax is unambiguous enough that a trailing _ is no longer required in places it was for ReasonML and OCaml syntax. A codebase search for _: turns up quite a lot of them. Examples: https://github.com/tinymce/rescript-webapi/blob/ea9bd980f1b2b2d516e518f1f9c166feb1073f33/src/Webapi/Webapi__Blob.res#L10

https://github.com/tinymce/rescript-webapi/blob/253ba954381a78b57bad249ea83c1f5b6ab2b428/src/Webapi/Dom/Webapi__Dom__HtmlFormElement.res#L17

The compiler will signal when removing the underscore is not allowed, making this a mostly trivial change (but some tests would be nice)

Contributor guide

Research direction
Search the codebase for ` :` patterns, remove trailing underscore where compiler permits, and run tests to ensure correctness.
Tech stack
None
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80