ThePhrozenKeep/D2MOO

Incorrect logic in `ACT1Q2_Callback03_ChangedLevel`

Open

#227 opened on Jul 8, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (48 forks)auto 404
buggood first issue

Repository metrics

Stars
 (159 stars)
PR merge metrics
 (PR metrics pending)

Description

the following branch will never trigger https://github.com/ThePhrozenKeep/D2MOO/blob/19019806df7f3e877fa105b05395d1e3597e2316/source/D2Game/src/QUESTS/ACT1/A1Q2.cpp#L478 due to this branch a few lines before: https://github.com/ThePhrozenKeep/D2MOO/blob/19019806df7f3e877fa105b05395d1e3597e2316/source/D2Game/src/QUESTS/ACT1/A1Q2.cpp#L465

In vanilla this case is handled by a boolean stored on the stack that will be set by the first check on pQuestData->fState. This was verified by the 1.13c assembly at D2Game.0x64EE9 (its a bit tooo complex to post inline unfortunately).

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.