danielaparker::jsoncons traits fail with version >=1.5.0 of jsoncons
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- cpp
- Domain
- authentication
Research direction
Start in include/jwt-cpp/traits/danielaparker-jsoncons/traits.h, focusing on the jsoncons::json_type names shown in the compiler errors. Compare them with the referenced jsoncons upstream commit, then verify that the traits compile with jsoncons 1.5.0 or newer on GCC/Linux.
Written by the indexing model from the issue text.
Description
What happened?
Upstream has deprecated the type names int64_value etc. in 1.5.0, they are now just int64, leading to errors such as:
/var/tmp/portage/dev-cpp/jwt-cpp-0.7.2/work/jwt-cpp-0.7.2/include/jwt-cpp/traits/danielaparker-jsoncons/traits.h:125:72: error: ‘bool_value’ is not a member of ‘jsoncons::json_type’
125 | if (val.type() == jsoncons::json_type::bool_value) return type::boolean;
| ^~~~~~~~~~
/var/tmp/portage/dev-cpp/jwt-cpp-0.7.2/work/jwt-cpp-0.7.2/include/jwt-cpp/traits/danielaparker-jsoncons/traits.h:126:72: error: ‘int64_value’ is not a member of ‘jsoncons::json_type’
126 | if (val.type() == jsoncons::json_type::int64_value) return type::integer;
| ^~~~~~~~~~~
Relevant upstream commit:
https://github.com/danielaparker/jsoncons/commit/f070f9566a897fbdc7603553d960cf1907cdd72d
How To Reproduce?
Use jsoncons >= 1.5.0.
Version
0.7.2
What OS are you seeing the problem on?
Linux
What compiler are you seeing the problem on?
GCC
Relevant log output
/var/tmp/portage/dev-cpp/jwt-cpp-0.7.2/work/jwt-cpp-0.7.2/include/jwt-cpp/traits/danielaparker-jsoncons/traits.h:125:72: error: ‘bool_value’ is not a member of ‘jsoncons::json_type’
125 | if (val.type() == jsoncons::json_type::bool_value) return type::boolean;
| ^~~~~~~~~~
/var/tmp/portage/dev-cpp/jwt-cpp-0.7.2/work/jwt-cpp-0.7.2/include/jwt-cpp/traits/danielaparker-jsoncons/traits.h:126:72: error: ‘int64_value’ is not a member of ‘jsoncons::json_type’
126 | if (val.type() == jsoncons::json_type::int64_value) return type::integer;
| ^~~~~~~~~~~
Code of Conduct
- I agree to follow this project's Code of Conduct
- Dominant language
- C++
- Stars
- 1.2k
- Forks
- 311
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Thalhammer/jwt-cpp
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
Thalhammer/jwt-cpp#433 ·
-
question
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Thalhammer/jwt-cpp#426 · 1 comment ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
Thalhammer/jwt-cpp#418 ·
-
enhancement look into question
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Thalhammer/jwt-cpp#399 · 1 comment ·
-
BoringSSL? Openenhancement question
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Thalhammer/jwt-cpp#396 · 2 comments ·
All issues in Thalhammer/jwt-cpp
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·