Tensegritics/ClojureDart

Add support for :extend-via-metadata in protocol definitions

Open

#218 opened on Apr 3, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Clojure (1,618 stars) (115 forks)batch import
enhancementgood first issue

Description

Describe the bug Code can not be compiled once defprotocol elect to be extended via per-value metadata.

To Reproduce Steps to reproduce the behavior:

  1. Create a CLJD project
  2. Try to compile this code:
(defprotocol  MyProtocol :extend-via-metadata true
              (some-fn [this]))
  1. See error
Don't know how to create ISeq from: clojure.lang.Keyword
Faulty form (defprotocol MyProtocol :extend-via-metadata true (some-fn [this]))

Expected behavior

  • code can be compiled and metadata + protocols can be used.

Additional context

  • I have experienced this error when trying to use Honey.SQL in CLJD

Contributor guide

Tech stack
dartflutter
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Clojure protocol systemClojureDart compiler basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the defprotocol macro implementation in the ClojureDart compiler, focusing on the handling of :extend via metadata. The error 'Don't know how to create ISeq from: clojure.lang.Keyword' indicates a parsing issue where a keyword is not being properly processed in the protocol definition. Look at the relevant parser functions and test similar Clojure features to understand the expected behavior.