Tensegritics/ClojureDart

Port new 1.11 behavior for associative varargs

Open

#109 opened on Jun 13, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Clojure (115 forks)batch import
help wanted

Repository metrics

Stars
 (1,618 stars)
PR merge metrics
 (Avg merge 8d) (2 merged PRs in 30d)

Description

I think this is related to issue #96.

Calling a variadic function that contains argument destructuring fails with the following exception: Unhandled Exception: Invalid argument(s): Index out of bounds

Example:

(defn one [& {:keys [a b]
              :or {a "a" b "b"}}]
  (dart:core/print (str a b)))

  (one) ;=> ab
  (one nil) ;=> ...Index out of bounds...
  (one {}) ;=> ...Index out of bounds...
  (one {:a "x"}) ;=> ...Index out of bounds...
  (one {:a "x" :b "y"}) ;=> ...Index out of bounds...


(defn two [a & {:keys [b c]
                :or {b "b" c "c"}}]
  (dart:core/print (str a b c)))
  
  (two "x") ;=> xbc
  (two "x" nil) ;=> ...Index out of bounds...
  (two "x" {}) ;=> ...Index out of bounds...
  (two "x" {:b "y"}) ;=> ...Index out of bounds...
  (two "x" {:b "y" :c "z"}) ;=> ...Index out of bounds...

Contributor guide

Research direction
Study the Clojure 1.11 implementation for associative destructuring in variadic functions (e.g., `& {:keys ...}`). Examine the ClojureDart compiler's handling of variadic arguments and destructuring. Identify where the index out of bounds error originates and modify to match the new behavior.
Tech stack
clojureflutter
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Clojuredestructuringvariadic functions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60