Tencent/matrix

Matrix IO检测：只hook主线程IO的限制去掉之后，触发ANR

Open

#146 opened on Mar 25, 2019

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Java (11,267 stars) (1,839 forks)batch import
help wanted

Description

 int ProxyOpen(const char *pathname, int flags, mode_t mode) {
            if(!IsMainThread() && !ignore_main_thread_limit) {
                return original_open(pathname, flags, mode);
            }

            int ret = original_open(pathname, flags, mode);

            if (ret != -1) {
                    DoProxyOpenLogic(pathname, flags, mode, ret, IsMainThread());
            }

            return ret;
        }

代码如上，ignore_main_thread_limit==true；运行代码ANR； 为什么small_buffer、repreat_read检测也需要限制到主线程？

Contributor guide

Tech stack
androidjavacpp
Domain
mobileperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android threading basicsC/C++ IO operationsMatrix IO detection module
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the reason why `small buffer` and `repeat read` detections also need to be limited to the main thread. Look into the `DoProxyOpenLogic` function and the original implementation that introduced `ignore main thread limit`. Check the Matrix IO detection source code and any related issues or pull requests for context. The fix may involve re adding the main thread check for these specific detections or understanding why it was removed.