TeamNewPipe/NewPipe

refactor download manager

Open

#962 opened on Jan 5, 2018

View on GitHub
 (72 comments) (19 reactions) (0 assignees)Java (38,153 stars) (3,577 forks)batch import
bountydownloaderfeature requesthelp wanted

Description

bounty

  • [5] I carefully read the contribution guidelines and agree to them.
  • [no] I checked if the issue/feature exists in the latest version.

Gigaget wase once a downloader distributed on fdroid. However it is discontinued, tho we copypasted their code into NewPipe, and made gigaget our downloader. Now we have to get rid of it, since its causing a lot of trouble. Related issues: https://github.com/TeamNewPipe/NewPipe/issues/961 https://github.com/TeamNewPipe/NewPipe/issues/779 https://github.com/TeamNewPipe/NewPipe/issues/355 https://github.com/TeamNewPipe/NewPipe/issues/345 https://github.com/TeamNewPipe/NewPipe/issues/315

Maybe we could replace it with a Download Manager available on Android Arsenal. Feel free to browse a little and find a downloader you think fits to NewPipe.

A new download manager must have these abilities:

  • using SAF (for downloading to sdcard)
  • Be singe threaded (one thread per download)

Nice to have:

  • Prevent/restrict download on mobile connection
  • download files with external download manager #9142
  • easy accessing videos form download manager
  • make it a lib and put it back on android arsenal
  • show download status in titlebar/notification

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android developmentJavaunderstanding of SAF
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10
Research direction
The issue requires replacing Gigaget, a discontinued download manager that was copied into NewPipe, with a new download manager that supports SAF and single threaded downloads. Research existing download manager libraries on Android Arsenal, evaluate their features, and integrate one. Ensure the solution addresses related issues (e.g., #961, #779). The new manager should be a reusable library. Start by reviewing the current Gigaget implementation in the repository.