code qualityhelp wantedplayerrewrite
Repository metrics
- Stars
- (38,153 stars)
- PR merge metrics
- (Avg merge 9d 17h) (17 merged PRs in 30d)
Description
I and Stypox noticed some strange things while reviewing/refactoring the player https://github.com/TeamNewPipe/NewPipe/pull/8170 (which were also there before the refactoring):
- When the playerservice is removed the complete app is killed (not gracefully terminated) by calling
Runtime.getRuntime().halt(0): https://github.com/TeamNewPipe/NewPipe/pull/8170#discussion_r865168043 - https://github.com/TeamNewPipe/NewPipe/pull/8170#discussion_r915709223 - here somehow a velocity is set to a position.
- https://github.com/TeamNewPipe/NewPipe/blob/d9af7885140560a6373c1a8863aa381cdd8ed170/app/src/main/java/org/schabi/newpipe/player/Player.java#L2584 should be addressed (or removed) https://github.com/TeamNewPipe/NewPipe/pull/8170#discussion_r917277853
- https://github.com/TeamNewPipe/NewPipe/blob/e9e9e8096ca6838a259250ed0f83d3c986dc64b2/app/src/main/java/org/schabi/newpipe/player/mediasession/MediaSessionPlayerUi.java#L70 should be addressed (or removed) https://github.com/TeamNewPipe/NewPipe/pull/8678#discussion_r928249638
Other things to do:
- Add an UI that handles setting up a media session to send media information to the system, and try to fix the various issues with the player notification (e.g. wrong thumbnail, non-seekable current time, ...): #8678
- Properly implement a Picture In Picture popup: #8750
- Make the playback parameters menu show up even when in popup mode
- https://github.com/TeamNewPipe/NewPipe/pull/8170#issuecomment-1228887994
- Refactor how the player is started or changed: #7673