TeamNewPipe/NewPipe

List fragment not restoring items after rotating and going to recent apps

Open

#7,909 opened on Feb 19, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (3,577 forks)batch import
GUIbughelp wanted

Repository metrics

Stars
 (38,153 stars)
PR merge metrics
 (Avg merge 9d 17h) (17 merged PRs in 30d)

Description

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

After (but also before) #7659

Steps to reproduce the bug

Search something (note: this might happen for other fragments, too); then press Android's square button (to view recent apps) and rotate the device at the same time; then go back to the app.

Expected behavior

All of the search items loaded so far are shown instantaneously, like what already happens when the app just resumes from recents (e.g. because its state was saved to disk after a RAM shortage).

Actual behavior

The (search) fragment starts reloading the list from the beginning.

Contributor guide

Research direction
Investigate the fragment lifecycle and state saving mechanism in SearchFragment. Focus on onSaveInstanceState and onRestoreInstanceState methods, and the behavior when the activity is recreated after rotation and going to recent apps. Check if the list adapter and loaded items are properly saved and restored.
Tech stack
java
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android developmentJavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60