TeamNewPipe/NewPipe

Standardize view animation duration

Open

#3,038 opened on Jan 30, 2020

View on GitHub
 (11 comments) (3 reactions) (0 assignees)Java (38,153 stars) (3,577 forks)batch import
GUIfeature requestgood first issue

Description

If you check the usages of animateView you will see that the typical range will be 0 all the way to 500, with most in the 100-250 range.

It should've been done with a default value in the first place. It is pretty much arbitrary right now, it was whatever the person felt like at the time of writing.

I'll leave this task to another PR, which the goal will be to standardize the used duration of animations.

_Originally posted by @mauriciocolli in https://github.com/TeamNewPipe/NewPipe/pull/2309#discussion_r371625549

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaAndroid developmentAnimateView methodGitHub workflow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Locate all usages of the animateView method in the NewPipe codebase (likely in app/src/main/java). Review the discussion in PR #2309 (comment by @mauriciocolli) for context. Propose a standard duration (e.g., 200ms) and update each call for consistency. Consider adding a default duration constant.
Standardize view animation duration · TeamNewPipe/NewPipe#3038 | Good First Issue