TeamNewPipe/NewPipe

The app crashes when searching in the settings in landscape mode

Open

#11,915 opened on Jan 14, 2025

View on GitHub
 (4 comments) (1 reaction) (1 assignee)Java (38,153 stars) (3,577 forks)batch import
buggood first issuesearch

Description

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.4（latest build)

Steps to reproduce the bug

  1. go settings
  2. click search button
  3. click the content below the search box, and the app will enter the corresponding sub-setting page
  4. rotating devices and go back to the main settings page
  5. click search button and app crash

Expected behavior

show search box

Actual behavior

crash

Screenshots/Screen recordings

https://github.com/user-attachments/assets/f2f75b9a-79a4-40cd-b5b6-ae713a51a61c

Logs

 java.lang.IllegalStateException: Fragment already added: PreferenceSearchFragment{c45cd8e} (1efce92d-66a0-43b9-b9a5-ffa301582699 id=0x7f0a0359 tag=PreferenceSearchFragment)
         at androidx.fragment.app.FragmentStore.addFragment(FragmentStore.java:93)
         at androidx.fragment.app.FragmentManager.addFragment(FragmentManager.java:1503)
         at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:387)
         at androidx.fragment.app.FragmentManager.executeOps(FragmentManager.java:2009)
         at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1895)
         at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1839)
         at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
         at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)
         at android.os.Handler.handleCallback(Handler.java:938)
         at android.os.Handler.dispatchMessage(Handler.java:99)
         at android.os.Looper.loop(Looper.java:223)
         at android.app.ActivityThread.main(ActivityThread.java:7656)
         at java.lang.reflect.Method.invoke(Native Method)
         at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

Affected Android/Custom ROM version

android11

Affected device model

google nexus4

Additional information

No response

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android fragment lifecycleJavaConfiguration change handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the fragment management in settings, particularly the PreferenceSearchFragment. Check the `onCreate` or `onCreateView` of SettingsFragment for how the search fragment is added. Ensure that when rotating, the fragment is not added again if already present. Look at existing PRs or comments for similar fixes.